Skip to content

Prepare for v0.7.0 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Prepare for v0.7.0 #286

merged 3 commits into from
Nov 10, 2020

Conversation

adamgreig
Copy link
Member

I think I got everything in the changelog updates but please point out anything I missed. Anything else missing before we're ready for 0.7.0?

Note that my plan is to now release cortex-m-semihosting 0.3.6 (with support for cortex-m >0.5&&<0.8) and 0.4.2 (cortex-m ^0.7, with our recent breaking changes) after cortex-m 0.7 is out.

@rust-highfive
Copy link

r? @jonas-schievink

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Nov 9, 2020
@adamgreig
Copy link
Member Author

NB closes #281

@jonas-schievink
Copy link
Contributor

Don't think I currently have time to review this. r? @therealprof

Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, regarding CI, it seems like we hit rust-lang/rust#39935

@thalesfragoso
Copy link
Member

Oh, another thing, I thought we would incorporate panic-itm before releasing 0.7.0, is this still the plan ?

@adamgreig
Copy link
Member Author

Oh, another thing, I thought we would incorporate panic-itm before releasing 0.7.0, is this still the plan ?

We can merge panic-itm into this repository after releasing 0.7, and then make a new release of panic-itm with updated links and a dependency allowing use with cortex-m 0.7 at the same time. Since the crates still get published separately (at least for now), there's no need to merge it before cortex-m 0.7 is released, as I understand it anyway.

@hug-dev
Copy link
Contributor

hug-dev commented Nov 10, 2020

Are the items in the src/peripheral/sau.rs going to be released as well?

@adamgreig
Copy link
Member Author

Are the items in the src/peripheral/sau.rs going to be released as well?

Yep, I missed those off the CHANGELOG updates somehow. Everything in the current master branch will be included. I'll update the changelog, thanks!

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, went through all the changes and I think it's complete.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 10, 2020

👎 Rejected by code reviews

@therealprof
Copy link
Contributor

@thalesfragoso Happy? If so could you remove the change request?

Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for holding this, I thought my review would be dismissed by the new changes. Anyways, thanks again!

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 10, 2020

Build succeeded:

@bors bors bot merged commit bc8c562 into master Nov 10, 2020
@bors bors bot deleted the v0.7.0 branch November 10, 2020 22:34
@adamgreig
Copy link
Member Author

v0.7.0 is released 🎉

adamgreig pushed a commit that referenced this pull request Jan 12, 2022
286: Fix possible overflow of .data region in FLASH r=jonas-schievink a=Guilucand

Hi,

i found a bug on the size checking of the FLASH region, that in some cases allows it to be larger than it's defined size.
This happens because the .data section is placed on a FLASH address (at the end of __erodata) but it's not checked against the FLASH region size.
Changing the section as shown solves the issue.

Co-authored-by: Guilucand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants